Lucas_Werkmeister_WMDE added a comment.
I guess we can keep using this task, but if it was previously prioritized for just the last AC, we need to reprioritize it again. (But my impression is that it wasn’t really prioritized at all, at least not after the workflow was fixed last time.) Comparing the history of lib/packages/wikibase/data-model in Wikibase <https://github.com/wikimedia/mediawiki-extensions-Wikibase/commits/master/lib/packages/wikibase/data-model> and the history of wmde/WikibaseDataModel <https://web.archive.org/web/20231222115427/https://github.com/wmde/WikibaseDataModel/commits/master/>, I notice that both of them have “Remove obsolete comments and enable FunctionComment.WrongStyle sniff”, but after that, WikibaseDataModel jumps directly to “Drop reimplementations of is_iterable() & iterator_to_array()”, somehow skipping “EntityId: Remove Serializable interface and methods” and “EntityId: Assert valid serialization in unserialize()”. I don’t know how this could’ve happened (I don’t remember us force-pushing anything in Wikibase), but I think we might have to force-push WikibaseDataModel to resolve this 😖 TASK DETAIL https://phabricator.wikimedia.org/T314987 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, Michael, Tarrow, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
