Michael added a comment.

  In T353957#9441083 <https://phabricator.wikimedia.org/T353957#9441083>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T353957#9435658 <https://phabricator.wikimedia.org/T353957#9435658>, 
@Michael wrote:
  >
  >> That is it! We're not cloning MediaWiki here, we're downloading it via 
`wget -O- https://github.com/wikimedia/mediawiki/archive/$MW_BRANCH.tar.gz` and 
the `.gitattributes` file has `phpunit.xml.dist export-ignore`, so that file is 
not included there.
  >
  > Jeeeeeeez. Thanks for figuring that out ^^
  >
  > Apparently the motivation for that is “to keep DocumentRoot clear for 
tar-ball installs” (Gerrit comment 
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519165/comment/503eeadb_c07293b0/>);
 `tests/` instead has an `.htaccess` file, so that’s why we don’t export-ignore 
all of `tests/`, I guess.
  >
  > We should probably just use a real `git clone`? With `--depth=1` it 
hopefully shouldn’t take much longer than downloading the tarball.
  
  Yeah, that's what I did in 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/987955 and 
it works fine. It should work here just as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T353957

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Daimona, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to