ArthurTaylor added a comment.

  Okay. So since the code currently throws an exception in these cases, and the 
exception is presented to the users in the document response, it seems that 
catching that in the library and throwing a more specific exception is not a 
product-relevant change. Let's tidy up how the library handles invalid input, 
make the exceptions regular, then file another bug for the `wbformatvalue` 
action to process the exceptions in a more friendly way.
  
  Per comment from in tech grooming @Lucas_Werkmeister_WMDE , we probably need 
to introduce the new exception class in the DataValues top-level library, and 
then throw it from the specific module (e.g. GeoValues).

TASK DETAIL
  https://phabricator.wikimedia.org/T323778

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor
Cc: ArthurTaylor, ItamarWMDE, Michael, Lucas_Werkmeister_WMDE, Aklapper, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to