Sarai-WMDE added a comment.
This looks great! I only found a couple of small things to fix: 1. **Footer padding**: The horizontal padding of the Footer is not matching the specs/ aligned with the page margins (it remains 24px above the 1120px breakpoint, it becomes 16px below 720px instead of 640px) 2. **Heading wrapping**: Even if a gap has been implemented between the headings and their adjacent buttons, the buttons still don't take the space that is made available for then when the titles wrap (they display ellipsis even if there's enough room for them). I believe there's an easy fix for this: we just need to target these buttons and apply`flex-shrink: 0;` to them (see clarifying screenshots below). | Current state in staging | With flex-shrink 0 | | F41735650: Screenshot 2024-01-31 at 20.30.56.png <https://phabricator.wikimedia.org/F41735650> | F41735652: Screenshot 2024-01-31 at 20.31.42.png <https://phabricator.wikimedia.org/F41735652> | | There's enough space for the button, but it still displays ellipsis. | The button takes the available space | | TASK DETAIL https://phabricator.wikimedia.org/T348729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
