Sarai-WMDE added a comment.

  Hey there! The table is looking good. I only found the following necessary 
fix:
  
  - **Select menu options**: For some reason, the menu items are now displaying 
a `margin-inline-start`of 1rem that shouldn't be there.
  
  F41738697: Screenshot 2024-02-01 at 10.18.15.png 
<https://phabricator.wikimedia.org/F41738697>
  
  The following doesn't need fixing, but I think it's a good idea to document 
it for our future selves:
  
  MSMF Tables still linearise (become lists for responsiveness) at the (new) 
tablet breakpoint of 1120px. This is a bit "too early" (there's still 
sufficient space for the default table shape at that viewport size). We can 
apply a custom breakpoint to them to improve their readability in a separate 
task. I added this change to this ticket, but didn't make it an AC, so too bad. 
I also indicated 800px, which probably needs adjustment due to the recent grid 
changes. In any case, this is not urgent nor essential, just an enhancement for 
the future.

TASK DETAIL
  https://phabricator.wikimedia.org/T348271

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: noarave, HasanAkgun_WMDE, karapayneWMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to