Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Technical-Debt. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION In build: Updating mediawiki/mediawiki-phan-config to 0.14.0 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1004777>, two Phan issue types were temporarily suppressed. We should actually fix our code according to the coding conventions (linked below) and remove these suppressions. [ ] `MediaWikiNoBaseException`: Don’t throw `\Exception`; see exception handling <https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Exception_handling>. [ ] `MediaWikiNoEmptyIfDefined`: Don’t use `empty()` on variables that are always set; see empty() <https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#empty()>. TASK DETAIL https://phabricator.wikimedia.org/T358325 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
