Nikki added a comment.
I think that patch should fix 2, 3, 5, 6, 7, 9 and 10 from the description. 1 and 4 are the triangular expand/collapse toggle icons. It would be possible to override the styles for it on the elements where Wikibase uses it, but I didn't include that because I have no idea which file to put it in or if I would even be allowed to do that. It wouldn't be ideal, those icons are PNGs, so scaling them up makes them slightly fuzzy. I would argue that it's still be an improvement, because crisp edges are not much use to you if it's not big enough for you see what it is. Here's how it looks scaled up for me with Chrome's "large" and "very large" default font sizes (150% and 200% I think): F44458726: Bildschirmfoto_2024-04-04_10-02-52.png <https://phabricator.wikimedia.org/F44458726> F44458733: Bildschirmfoto_2024-04-04_10-02-31.png <https://phabricator.wikimedia.org/F44458733> The rest of the changes are in different repositories (WikibaseLexeme and EntitySchema). I can make those use relative sizes too, but the icons in both of those extensions are inconsistent with the rest of the site, so if I do, I would really like to make them consistent (maybe most people don't notice, but //I// do), not just change the units: The icons for lemmas claim to have been copied from `.wikibase-toolbar-button .wb-icon` (link <https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseLexeme/+/5aff4a8d34dfd211cf8aa1e82f7ebad0eef28d94/resources/lemma-widget.less#48>), but the size and opacity are different (20px instead of 16px, 0.7 opacity instead of 0.87). Screenshots of how the lemma buttons (at the top) and the senses buttons (at the bottom) currently look at a normal font size on the same page: F44459972: Bildschirmfoto_2024-04-04_10-39-37.png <https://phabricator.wikimedia.org/F44459972> F44459973: Bildschirmfoto_2024-04-04_10-39-21.png <https://phabricator.wikimedia.org/F44459973> The icons for entity schemas also claim to have been copied from `.wikibase-toolbar-button .wb-icon` (link <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/EntitySchema/+/refs/heads/master/resources/viewEntitySchema.less#5>) but the size, opacity and colour are all different (15px instead of 16px, 0.67 opacity instead of 0.87, blue instead of black). Screenshot of how the edit buttons on entity schema pages currently look at a normal font size: F44460476: Bildschirmfoto_2024-04-04_10-46-23.png <https://phabricator.wikimedia.org/F44460476> TASK DETAIL https://phabricator.wikimedia.org/T328387 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Nikki Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, Nikki, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
