ArthurTaylor added subscribers: Lucas_Werkmeister_WMDE, Jakob_WMDE.
ArthurTaylor added a comment.
Tested this with the latest patches from @Lucas_Werkmeister_WMDE . It mostly
works - the expert is there and does the correct search and finds results by ID
- but when you click a value from the dropdown, the call to `wbparsevalue`
fails:
curl
'http://wikidatawikidev.mediawiki.mwdd.localhost:8080/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=%1FE31&errorformat=plaintext&uselang=en&options=%7B%22lang%22%3A%22en%22%7D'
(vs. the comparable call from the Lexeme expert, which succeeds:
curl
'http://wikidatawikidev.mediawiki.mwdd.localhost:8080/w/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=%1FL1&errorformat=plaintext&uselang=en&options=%7B%22lang%22%3A%22en%22%7D'
I had a chat with @Jakob_WMDE about this, and we agreed a plan:
- Override the ValueParser for the EntitySchema expert so that it supplies
different parameters to the `wbparsevalue` API call:
- drop the `parser` parameter (which is deprecated)
- supply the `datatype` or `property` parameter
- Refactor the entity schema value parser (introduced in 994206
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/994206>)
to expect strings instead of arrays and adjust all places that call it
accordingly
I'll take a look at these and update my patch.
TASK DETAIL
https://phabricator.wikimedia.org/T362004
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ArthurTaylor
Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, ArthurTaylor, Aklapper, Arian_Bozorg,
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414,
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657,
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978,
ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, pdehaye,
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86,
Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden,
YULdigitalpreservation, KimKelting, LawExplorer, Salgo60, Lewizho99, Maathavan,
_jensen, rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian,
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
