thiemowmde closed this task as "Resolved". thiemowmde added a comment.
I ended adding a bit of extra-pedantic code that validates the language before using it, see https://gerrit.wikimedia.org/r/1037430. I think this is reasonable. This class already does language validation anyway. Alternatives are: - Change core and the core parser so it doesn't forward invalid language codes. However, I'm not sure how complicated this is or if it's even possible as it might have unwanted side-effects. - Make the responsible code in Wikibase validate the language before using it. However, doing so would feel quite misplaced. All this code appears to do is to forward an existing `Language` object. Why should it expect that to be invalid? TASK DETAIL https://phabricator.wikimedia.org/T288150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, TheDJ, Aklapper, mmodell, Ullasoff, Danny_Benjafield_WMDE, S8321414, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Alilje, darthmon_wmde, Nabetaro, Rosalie_WMDE, Nandana, MSantos, lucamauri, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, KimKelting, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Verdy_p, Planemad, Wikidata-bugs, aude, awight, Yurik, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
