GreenReaper created this task.
GreenReaper added a project: Wikidata Query UI.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **Steps to replicate the issue** (include links if applicable):
  
  - Load https://query.wikidata.org on Edge Dev 127 (or probably Chrome Dev)
  - There is no obvious issue but a deprecation warning/violation fires
  
  **What happens?**:
  The following warnings are logged in the console:
  
    vendor.min.fb6bdb8….js:1 [Violation] Listener added for a 
'DOMSubtreeModified' mutation event. This event type is deprecated, and will be 
removed from this browser VERY soon. Usage of this event listener will cause 
performance issues today, and represents a large risk of imminent site 
breakage. Consider using MutationObserver instead. See 
https://chromestatus.com/feature/5083947249172480 for more information.
    vendor.min.fb6bdb8….js:1 [Deprecation] Listener added for a 
'DOMSubtreeModified' mutation event. This event type is deprecated, and will be 
removed from this browser VERY soon. Usage of this event listener will cause 
performance issues today, and represents a large risk of imminent site 
breakage. Consider using MutationObserver instead. See 
https://chromestatus.com/feature/5083947249172480 for more information.
  
  **What should have happened instead?**:
  
  There should have been no deprecation warning.
  
  The code concerned appears to be in App.js 
<https://github.com/wikimedia/wikidata-query-gui/blob/da379757474aa5044aa64106095b618d1c9b5e45/wikibase/queryService/ui/App.js#L470>
 (compiled to wdqs.js), _initQueryHelper,
  
    $( '.query-helper' ).bind( 'DOMSubtreeModified', _.debounce( function () {
        self._updateQueryHelperMinWidth();
        self._updateQueryEditorSize();
    }, 100 ) );
  
  Overriding to remove this code removes the deprecation warning, but the width 
of the query helper and editor windows are no longer updated when long-named 
items are selected in the helper, causing them to overflow the helper panel.
  
  **Other information** (browser name/version, screenshots, etc.):
  
  Microsoft Edge Version 127.0.2620.3 (Official build) dev (64-bit)

TASK DETAIL
  https://phabricator.wikimedia.org/T366866

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: GreenReaper
Cc: Aklapper, GreenReaper, AWesterinen, Namenlos314, Gq86, 
Lucas_Werkmeister_WMDE, Mahir256, EBjune, KimKelting, merbst, Salgo60, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to