thiemowmde added a comment.

No, this is not a regression. There are probably hundreds of surprising and 
confusing strings PHP's parser accepts, for example "2015-01-31+1month 
<https://www.wikidata.org/w/api.php?action=wbparsevalue&format=json&parser=time&values=2015-01-31+1month>".
 We already blocked some known cases.

The current architecture is build like this:

- First, use a "white list" of known date formats. This includes a parser for 
ISO-like strings, month and year with no day and all the different years we 
support (e.g. "1 Million BC").
- Then, use a "black list" for values that will be parsed in an unexpected way 
when passed to PHP's parser. This includes values with no digits, values that 
contain nothing but a timezone (see PhpDateTimeParser::validateDateTimeInput) 
and values that trigger calculations on the year (see 
PhpDateTimeParser::stringParse).
- All values that made it that far are passed to PHP's parser.


TASK DETAIL
  https://phabricator.wikimedia.org/T104862

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Addshore, thiemowmde, Tobi_WMDE_SW, Lydia_Pintscher, Nikki, Aklapper, 
Wikidata-bugs, aude, Malyacko, P.Copp



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to