thiemowmde added a project: Patch-For-Review. thiemowmde added a comment. @JanZerebecki wrote:
> That methods change their hidden argument $this is why they are called > methods. So unless you want to object to using methods in general... I'm very sorry, but I do not understand. > PHP does COW. Yes, and as PHP developers we can not control it. It may even happen when `count`ing an array. I regularly run into //major// performance issues in production code because of this. However, the bigger chunk of this task is done anyway, with a single exception I can find: - https://github.com/DataValues/Serialization/pull/12 All other deserializers already became stateless over the past months: - https://github.com/wmde/WikibaseInternalSerialization/pull/69 (merged) - https://github.com/wmde/WikibaseInternalSerialization/pull/75 (merged) - https://github.com/wmde/WikibaseInternalSerialization/pull/76 (merged) - https://github.com/wmde/WikibaseInternalSerialization/pull/77 (merged) TASK DETAIL https://phabricator.wikimedia.org/T98124 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: JanZerebecki, JeroenDeDauw, thiemowmde, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
