ori added a subscriber: MaxSem. ori added a comment. @MaxSem looked at this code and instantly noticed that it is repeatedly sorting the cached value whenever it is retrieved (actually, whenever the method is called), and remarked that it would be far more sensible to do this once, when //saving// the value.
TASK DETAIL https://phabricator.wikimedia.org/T113665 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ori Cc: MaxSem, JeroenDeDauw, daniel, hoo, aude, ori, Aklapper, Wikidata-bugs _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
