Sumit added a subscriber: Sumit.
Sumit added a comment.

In https://phabricator.wikimedia.org/T107941#1508776, @tstarling wrote:

> The API output is correct. That parser function returns no text, and sets a 
> property with name "wpb-banner-options". The extension uses a 
> BeforePageDisplay hook to modify the HTML depending on the wpb-banner-options 
> property. The action=expandtemplates module does not, and should not, call 
> the BeforePageDisplay hook.


Yes, WikidataPageBanner only adds banner HTML in BeforePageDisplay hook. Is 
there a way to return banner HTML during parse, or a place where a similar 
functionality has been implemented before?


TASK DETAIL
  https://phabricator.wikimedia.org/T107941

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit
Cc: Sumit, Ricordisamoa, tstarling, ssastry, Aklapper, Jdlrobson, Jrf, 
Husun1297, Wikidata-bugs, Ryasmeen, Etonkovidova, aude, Swainr, 
Lydia_Pintscher, Arlolra, Jdforrester-WMF



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to