adrianheine added a comment.

In https://phabricator.wikimedia.org/T78007#1782201, @thiemowmde wrote:

> - "add" and "remove" is not more or less information than "type" or "data".
> - Not sure what's wrong with Daniels suggestion. I'm fine with it, including 
> "source" and "data", which by the way was also in the original proposal.


`type` should be the only key that's known to the 
factory/deserializer/whatever. `data` is internal to `ListContentLanguages`. 
The class responsible for performing a union does not know about sources and 
data literals, it just knows about two (or more) `ContentLanguages`. `source` 
was not in my original proposal.


TASK DETAIL
  https://phabricator.wikimedia.org/T78007

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: Ricordisamoa, Tobi_WMDE_SW, JeroenDeDauw, Wikidata-bugs, jeblad, 
thiemowmde, JanZerebecki, adrianheine, Aklapper, Lydia_Pintscher, daniel, aude, 
Mbch331



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to