aude added a comment. problem is that (in some cases) we are validating an old version of an entity, with a specific change (label or description) patched into the entity.
the api call keeps passing the same baserevid even after subsequent edits in the term box. ModifyEntity uses baserevid when looking up the entity. e.g. I change the en label to "FOO", click save (with e.g. baserevid = 1), it validates "FOO" (label) + "old description" then change en description to "Wikipedia disambiguation page", click save (still baserevid = 1), it validates "old label" + "Wikipedia disambiguation page". then have an edit conflict, but it is able to be resolved. no further validation is done at this point, at least for label + description uniqueness. We should: 1. fix the UI to pass the correct baserevid 2. fix the backend so that validation is done when an entity gets patched due to edit conflict. (otherwise, there still is a way around the constraint if someone is directly using the api) TASK DETAIL https://phabricator.wikimedia.org/T121395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas, StudiesWorld, Wikidata-bugs, Mbch331 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
