ori reopened this task as "Open". ori added a comment.
Doing this via the job queue is not a good solution, in my opinion. There is something fundamentally broken about tying updates to parser cache events. Subscribing to changes via a ParserCacheSaveComplete hook handler is a bit like a department store updating its inventory any time a customer touches an item: sure, it covers all the relevant transactions, but it also creates a large amount of unnecessary work, because customers may handle an item for a number of reasons (to try it on or read the label), not all of which result in a transaction. ParserCacheSaveComplete events are the same way: they cover all the cases in which an edit is made, but they also fire in cases which do not involve a transaction. For example, the mobile and desktop web sites use different key-spaces to avoid polluting each other's parser cache entries with platform-specific artifacts. Hooking into ParserCacheSaveComplete is the wrong thing to do, because (AIUI) it isn't the really the parser cache that Wikibase cares about, and because it muddles the distinction between read-only and read/write requests. For example, RefreshLinks jobs may opportunistically refresh the parser cache <https://github.com/wikimedia/mediawiki/blob/6e9b4f0/includes/jobqueue/jobs/RefreshLinksJob.php#L187-L195>. The fact that Wikibase enqueues //another// job on ParserCacheSaveComplete makes it harder to reason about the job queue. Finally, like the example above, it creates a //large// amount of unnecessary work: when I commented out the hook for a few minutes yesterday (to investigate https://phabricator.wikimedia.org/T129517), I saw a marked drop in memcached traffic. TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ori Cc: ori, gerritbot, hoo, Addshore, Tobi_WMDE_SW, daniel, Lydia_Pintscher, Aklapper, aaron, D3r1ck01, Izno, Wikidata-bugs, aude, GWicke, Mbch331 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
