brion added a comment.
Thoughts: would RevisionContentLookup need both title and revision id in the same lookup, or should we rely on database integrity for ids, and have a separate lookup method as a shortcut for 'latest revision of page with this page id or title'? Slot name uniqueness/registration? Are we good enough with ad-hoc names? Hopefully extensions won't conflict, etc. we pret much have tons of cases where conflicts are possible though so this doesn't really increase our conflict surface. On the updater interfaces I'm not sure we need an explicit begin, versus implicitly beginning in the constructor (RAII)... Or are nested transactions still not safe to rely on? Hmmmm Derived and virtual slots still make me go "hmmm" as well though I can see some benefits. Need to think more as we flesh stuff out, get some good usage examples. I'll think about the xml dump format (do we have any notes on that I missed?) but it should be straightforward to add new elements alongside <text> to store the non-primary slots. What to do with derived and virtual slots on dump? I would tend to not include them I guess. TASK DETAIL https://phabricator.wikimedia.org/T107595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, brion Cc: RobLa-WMF, Yurik, ArielGlenn, APerson, TomT0m, Krenair, intracer, Tgr, Tobi_WMDE_SW, Addshore, Lydia_Pintscher, cscott, PleaseStand, awight, Ricordisamoa, GWicke, MarkTraceur, waldyrious, Legoktm, Aklapper, Jdforrester-WMF, Ltrlg, brion, Spage, MZMcBride, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, jayvdb, fbstj, Mbch331, Jay8g, bd808 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
