daniel added a comment.
In https://phabricator.wikimedia.org/T107595#2264511, @brion wrote: > and internally in the BlobStore's save method, we add the rollback callback straight onto the db object: > > That avoids having transaction state live separately in both the connection and a Transaction object. Good model? Bad model? This assumes the BlobStore will actually talk to the (same) database. I would like to have Transaction separate from the DB stuff, so it can be used just as well with files, or Cassandra, or Swift, or whatever we come up with to store blobs. We shouldn't assume that it knows about SQL at all. TASK DETAIL https://phabricator.wikimedia.org/T107595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: JJMC89, RobLa-WMF, Yurik, ArielGlenn, APerson, TomT0m, Krenair, intracer, Tgr, Tobi_WMDE_SW, Addshore, Lydia_Pintscher, cscott, PleaseStand, awight, Ricordisamoa, GWicke, MarkTraceur, waldyrious, Legoktm, Aklapper, Jdforrester-WMF, Ltrlg, brion, Spage, MZMcBride, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, jayvdb, fbstj, Mbch331, Jay8g, bd808 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
