thiemowmde added a comment.
Possible ways forward, as discussed today: 1. First, track how often the index feature is used. The critical line of code is in ChangeOpStatement. The only caller is the SetClaim API module. Track two numbers: Total calls of SetClaim and how often a non-null index is provided. 2. We could make MedieInfo implement StatementListHolder. But we want to avoid that. It will make the situation worse. 3. We could release https://phabricator.wikimedia.org/tag/wikibase-datamodel/ with https://github.com/wmde/WikibaseDataModel/pull/664, which added the possibility to move a statement to a specific position. Then implement a replacement for ByPropertyIdArray (or move it from https://phabricator.wikimedia.org/tag/wikibase-datamodel-services/ to https://phabricator.wikimedia.org/tag/mediawiki-extensions-wikibaserepository/). This replacement will not require StatementListHolder any more. 4. We can make ChangeOpStatement throw an exception when a user tries to specify an index on an entity type that does not implement StatementListHolder. Personally I like this very much and would love to work on a patch that does this. So personally, I suggest to pick 1 and 4 for the sprint. TASK DETAIL https://phabricator.wikimedia.org/T133853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gerritbot, hoo, daniel, Lydia_Pintscher, aude, JanZerebecki, JeroenDeDauw, adrianheine, Ricordisamoa, Bene, thiemowmde, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
