thiemowmde created this task. Herald added subscribers: Zppix, Aklapper. TASK DESCRIPTION PropertySuggester is extensively build on the assumption that all entity IDs can be represented as integer numbers via `getNumericId`. https://github.com/wmde/WikibaseDataModel/pull/667 provides a simple migration path: All entity types PropertySuggester must support (only Properties and Items) do have a getNumericId method anyway. Add a proper interface for that. Add `instanceof` and `is_int` checks to a few critical places, and be done for now. Wait for the exceptions and continue working on a proper fix (which basically means rewriting the entirety of PropertySugester) when these checks start to fail (which will most probably never happen). But the discussion dead-ended today. (WARNING) **Note:** Seems there is no tag for the PropertySuggester project.
TASK DETAIL https://phabricator.wikimedia.org/T135650 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: hoo, JeroenDeDauw, adrianheine, daniel, Lydia_Pintscher, Tobi_WMDE_SW, Aklapper, thiemowmde, Zppix, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331 _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
