thiemowmde added a comment.

I had an other look and as far as I can tell the _javascript_ implementation called EntityId was never used. Nowhere.

Selectors/suggesters are using Item and Property objects/stubs, but never an EntityId.

Item and Property are using strings, not EntityIds.

So I suggest to simply merge and release this the moment Wikibase.git depends on DataModel 6.1 (which introduced the "id" key). This can happen any time, somebody just needs to update composer.json to say ~6.1.

EntityId is mentioned by mistake in ViewFactory, which I'm going to fix.


TASK DETAIL
https://phabricator.wikimedia.org/T93172

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine, thiemowmde
Cc: thiemowmde, gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to