| Jdforrester-WMF added a comment. |
In T131132#2581101, @MZMcBride wrote:James F. has been pushing for this change, both filing this task and creating the various Gerrit changesets.
Just following-up on the long-term desire. :-) And yes, I was quite surprised how little of this had ever been captured in Phab/Bugzilla such that I had to create the tasks. It's been discussed many times; I believe I was in a panel discussion about it (and other related issues to editors understanding their liability and un-spilt-milk-ability) in Wikimania 2006, for instance.
This is great, but I think we absolutely must avoid the appearance that this change is being pushed through over objections.
Absolutely. This is why we announced it months ago in hundreds of venues, waited to give people time to consider and give feedback, and considered whether the feedback was sufficiently compelling as to decide not to do this (which is my totally-fun-and-not-in-any-way-controversial job ;-)). We did, several people have (above and elsewhere), and I have decided.
In T131132#2581092, @Platonides wrote:do not dare to touch the accesskey! (which would be tempting).
We haven't (as you can see in the code, at rMW74fa6071c2e5: EditPage: Allow the 'save' button's label to be 'publish' for public wikis for this change, and rMW347ec3352801: EditPage: Show a different label for the button on create vs. modify for the related "change" vs. "page" bit). I agree that breaking accesskeys is profoundly anti-accessibility and should be avoided unless there's a really strong reason.
I personally like the idea of naming it Save & something, also mentioned by @Alsee, be that Save and publish, Save and share with the word… whatever.
I've discussed this before a few times, but I can't immediately see where, so here goes:
PS: DYK that this button has been using "Save page" since the first phase3 revision, by Lee Daniel Crocker 13 years ago? And Magnus Manske original code (15 years ago) used "Save changes"
Yup, though I think it was briefly "Save article", for a year or so in between those two edits, and hence the message key name).
Cc: thiemowmde, thcipriani, Platonides, Dereckson, MZMcBride, tarlocesilion, Antanana, Alsee, Matthiasb, BethNaught, Kharkiv07, Philippe, Risker, Scott, APerson, John_Broughton, Whatamidoing-WMF, Ricordisamoa, Qgil, Base, Dispenser, Xaosflux, Florian, TerraCodes, Liuxinyu970226, Zppix, Deskana, Quiddity, Elitre, DLynch, gerritbot, TheDJ, Aklapper, Jdforrester-WMF, merbst, Lewizho99, Maathavan, Wess, D3r1ck01, Samtar, FloNight, Johan, Trizek-WMF, Izno, Psychoslave, Luke081515, Jrf, Husun1297, Wikidata-bugs, Etonkovidova, aude, GOIII, Gryllida, Swainr, Arrbee, KartikMistry, Mbch331, Jay8g, Keegan, Rdicerb
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
