hashar lowered the priority of this task from "Unbreak Now!" to "High".
hashar added a comment.

That has been worked around by skipping the faulty test whenever it is found to run via a specific Jenkins job. So at least is no more randomly blocking everyone (since the change got merged).

repo/tests/phpunit/includes/Notifications/JobQueueChangeNotificationSenderTest.php
class JobQueueChangeNotificationSenderTest extends PHPUnit_Framework_TestCase {

	public function setUp() {
		parent::setUp();

		$isFaultyJob = strpos(
			__DIR__,
			'mwext-Wikibase-repo-tests-sqlite-php55'
		) > 1;
		if ( $isFaultyJob ) {
			$this->markTestSkipped(
				'This test causes segfaults in mwext-Wikibase-repo-tests-sqlite-php55 jobs, skipping.'
			);
		}
	}

Still have to figure out the reason for the segfault but I would blame the Zend garbage collector there. We used to have it disabled (see above T142158#2638684 ). Might also look at Zend 5.5 patches which we might want to cherry pick in our Debian package.


TASK DETAIL
https://phabricator.wikimedia.org/T142158

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: aude, Addshore, Tobi_WMDE_SW, Stashbot, Jay8g, hashar, gerritbot, EBernhardson, matmarex, KartikMistry, Nikerabbit, daniel, hoo, bd808, greg, Paladox, dcausse, Legoktm, TerraCodes, Jdforrester-WMF, Luke081515, Krinkle, Aklapper, Lewizho99, Maathavan, D3r1ck01, Liudvikas, Izno, Wikidata-bugs, zeljkofilipin, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to