[Wikidata-bugs] [Maniphest] [Commented On] T147169: Make sure Wikibase dump maintenance scripts solely use the "dump" db group

[daniel]

daniel added a comment.

We probably could use DBConnRef here.

Two things about DBConnRef that I don't like:

• It hogs the connection until it is destroyed. That makes me feel uncomfortable to make it a member in a service. Services should not own a connection permanently.
• If your service needs read- and write connections, you have to pass in two DBConnRef objects.

Regarding using LoadBalancer: we can, but then you need to pass in three arguments: the LB, the wiki (db) name, and the groups. The ConnectionManager would bundle that info (just like DBConnRef does).

TASK DETAIL

https://phabricator.wikimedia.org/T147169

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: thiemowmde, Addshore, aaron, Aklapper, Smalyshev, Lydia_Pintscher, jcrespo, aude, daniel, hoo, D3r1ck01, Izno, Wikidata-bugs, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs