jcrespo added a comment.

DROP TABLE cognate_sites;
DROP TABLE cognate_titles;
DROP TABLE cognate_normalizations;


/*
 *Create the tables
 */


CREATE TABLE IF NOT EXISTS cognate_sites (

This is strange syntax. Normally, we want to DROP TABLE IF EXISTS, and force its creation, but anyway.

For the next tables, I do not fully understand:

CREATE TABLE IF NOT EXISTS cognate_sites (

Ok, you have defined a db name <-> wiki type + lang, which I assume it may be handy, but very small table. Not too relevant for the design decisions- if it is helpful, it is, end of discussion.

CREATE TABLE IF NOT EXISTS cognate_titles (

You separate the trio site, namespace, title- ok, but you do not give that a unique identifier, so this table is useless?

CREATE TABLE IF NOT EXISTS cognate_normalizations (

This is the only table creating a relationship, but it goes against everything we talked before- you use full titles (so no space is saved), and it is impossible, as it is now, to establish any kind of relationship between actual titles in this title column.

I am not saying this is wrong, but if it is right, you have changed completely the model you explained to me before, and I no longer understand it. There is an n:n relationship between raw title and cognate titles, and that makes no sense, because it is cross-wiki.


TASK DETAIL
https://phabricator.wikimedia.org/T148988

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jcrespo
Cc: hoo, Aklapper, jcrespo, Addshore, Marostegui, Minhnv-2809, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to