WMDE-leszek added a subscriber: thiemowmde. WMDE-leszek added a comment. |
While discussing https://gerrit.wikimedia.org/r/#/c/319321 @thiemowmde suggested to move checking that entity id belongs to the repository the lookup instance has been configured for down to WikiPageEntityMetaDataAccessor, instead of doing it in WikiPageEntityRevisionLookup.
We will do it as suggested. Note: I think this check should be only in "first-level" implementations of WikiPageEntityMetaDataAccessor interface, ie. in WikiPageEntityMetaDataLookup but not in PrefetchingWikiPageEntityMetaDataAccessor.
TASK DETAIL
EMAIL PREFERENCES
To: WMDE-leszek
Cc: thiemowmde, gerritbot, Aklapper, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
Cc: thiemowmde, gerritbot, Aklapper, daniel, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs