| daniel reopened this task as "Open". daniel added a comment. |
Reopening. Removing the warning may fix the symptom, but you are just shooting the messenger.
The warning is there for a reason, and needs to be put back. It should probably even be a production warning and use wfLogWarning(), since it is triggered by incomplete configuration. Wikibase will not function correctly if the localSiteID setting is incorrect, so the warning is needed. We can't just igore that situation, so the problem needs to be solved in a different way.
I see two things that need fixing:
- wfWarn should fail phpunit tests, but it perhaps should not fail qunit tests. How is that failure triggered? It seems like logging and error reporting on the CI system should be configured in a way that allows qunit tests to pass in the presence of warnings. This raises the question - why did this start to happen now? The warning has been there for years.
- The configuration on the CI system should not be incomplete in the first place. When using the example settings that define the local wiki ID to be "mywiki", "mywiki" must actually be a valid wiki ID (according to the sites table). So, either make sure "mywiki" is in the sites table of the CI system, or change the setting to something that is in the sites table. See Ia0d578a82152 for a patch that would remove the "mywiki" example, and fall back to using the database name as the site ID instead. Not sure that will Just Work on the CI system, though.
TASK DETAIL
EMAIL PREFERENCES
To: Tgr, daniel
Cc: KartikMistry, Amire80, santhosh, StudiesWorld, JanZerebecki, hoo, aude, Krinkle, Bene, demon, hashar, daniel, Lydia_Pintscher, thiemowmde, Nikerabbit, TerraCodes, Jay8g, gerritbot, Paladox, Aklapper, Tgr, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331
Cc: KartikMistry, Amire80, santhosh, StudiesWorld, JanZerebecki, hoo, aude, Krinkle, Bene, demon, hashar, daniel, Lydia_Pintscher, thiemowmde, Nikerabbit, TerraCodes, Jay8g, gerritbot, Paladox, Aklapper, Tgr, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
