| thiemowmde edited the task description. (Show Details) |
EDIT DETAILS
** [x] https://github.com/wmde/WikibaseDataModel/pull/718
** [x] https://github.com/wmde/WikibaseDataModel/pull/710
** [ ] https://github.com/wmde/WikibaseDataModel/pull/713 moves the equals() method from the base class to the only implementation, and rewrites the tests from scratch.
** [ ] https://github.com/wmde/WikibaseDataModel/pull/714 does the same with the getHash() method.
** [ ] https://github.com/wmde/WikibaseDataModel/pull/702~~https://github.com/wmde/WikibaseDataModel/pull/702 ~~ is Jeroens original patch. I suggest to use it as a template for future patches, but it does not need to be in this release.
* [ ] https://github.com/wmde/WikibaseDataModel/pull/654 is an unrelated (braking) bugfix I would like to see in this release.
...
* Required for federation:These patches are required for federation, and motivate the whole release. These patches remove the assumption that all EntityIds have a getNumericId method. Because of this we had to change a series of PHP serializations, which in effect changes all hashes of snaks, qualifiers, and references.** [x] https://github.com/wmde/WikibaseDataModel/pull/718
...
* @JeroenDeDauw started to refactor the HashArray base class away from SnakList:. This is technical debt we want to get rid of for a long time. These patches do not get rid of the technical debt, but move the code an entire mile in the direction we want by getting rid of an entire base class.** [x] https://github.com/wmde/WikibaseDataModel/pull/710
...
** [ ] https://github.com/wmde/WikibaseDataModel/pull/439 is an actual breaking change to SnakList. This removes 2 of 3 constructor parameters, along with the possibility to call it with null.** [ ] https://github.com/wmde/WikibaseDataModel/pull/713 moves the equals() method from the base class to the only implementation, and rewrites the tests from scratch.
** [ ] https://github.com/wmde/WikibaseDataModel/pull/714 does the same with the getHash() method.
** [ ] https://github.com/wmde/WikibaseDataModel/pull/702~~https://github.com/wmde/WikibaseDataModel/pull/702 ~~ is Jeroens original patch. I suggest to use it as a template for future patches, but it does not need to be in this release.
* [ ] https://github.com/wmde/WikibaseDataModel/pull/654 is an unrelated (braking) bugfix I would like to see in this release.
...
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: Lydia_Pintscher, WMDE-leszek, hoo, Addshore, aude, daniel, thiemowmde, JeroenDeDauw, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331
Cc: Lydia_Pintscher, WMDE-leszek, hoo, Addshore, aude, daniel, thiemowmde, JeroenDeDauw, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
