| WMDE-leszek added a comment. |
I haven't digested this proposal, and going even more further as @daniel outlined in his comment at https://gerrit.wikimedia.org/r/#/c/345292/, thus I don't feel ready to comment on the whole proposal.
My two cents so far:
- I like the idea of aiming to have no optional parameters in constructors/static constructor-like methods.
- it also seems more consistent to me if we say there shall be no constructor arguments at all. I could see why ID might be somewhat preferred to be allowed to be specified. On the other hand, one could argue that from what the entity stands for (ie. what it models), ID is probably least important. So it does more like "none or all" opposition to me.
- regarding names: "isSufficientlyInitialized" is not very nice name, same "isFullyInitialized", Maybe we could just say "isInitialized"? It should be clear that if e.g. language is missing from the Lexeme it is not "sufficiently" initialized, thus it is not really "initialized" yet.
- It is a valid point to say that limiting the change to the Lexeme as new entity type is going to make it more simple. OTOH it seems to me that it is "core" Wikibase (ie. the one with items and properties) that actually makes it pretty much required to instantiate incomplete entity objects. Therefore if we say this change is going to "improve" the situation, once could argue that items and properties should also be "fixed" in a similar way (and possibly they should be fixed in the first place). The point on longer parameter list of Lexeme's constructor is a valid one, though. On the other hand, currently Lexeme's constructor has one parameter more than Item's (with possible ways to wrap some of arguments to a thing like a Fingerprint for items/properties, which could reduce the parameter count - I am not saying this would be a good idea). I know there would be more parameters possibly coming (form and sense list, thus 2 params more). So there is some significant difference, I don't argue that.
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde, WMDE-leszek
Cc: gerritbot, Jakob_WMDE, Ladsgroup, Lydia_Pintscher, daniel, Aleksey_WMDE, Jonas, WMDE-leszek, thiemowmde, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331
Cc: gerritbot, Jakob_WMDE, Ladsgroup, Lydia_Pintscher, daniel, Aleksey_WMDE, Jonas, WMDE-leszek, thiemowmde, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
