thiemowmde added a comment. |
@Aleksey_WMDE, the problem is this line: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/Changes/EntityChange.php;52253d5b116df36849b2c44f787cbe3f256fedd2$201 This is code in lib, but it type hints against EntityContent and calls EntityContent::getEntityId, which is code in repo. This means lib depends on repo, right?
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: Aleksey_WMDE, thiemowmde, JeroenDeDauw, Ricordisamoa, Aklapper, Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel, QZanden, Izno, Mbch331
Cc: Aleksey_WMDE, thiemowmde, JeroenDeDauw, Ricordisamoa, Aklapper, Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel, QZanden, Izno, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs