daniel added a comment.

As to solving this issue: PropertyContent::isValid should at least check that the datatype is not empty. PropertyHandler::createEmptyEntity should probably fail.

But we should really make sure that properties can only be created with valid property types. EditEntity calls setDataTypeId in two places. The one that uses the value of $data['datatype'] directly should validate the data type first.


TASK DETAIL
https://phabricator.wikimedia.org/T166227

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: Rzuwig, aude, daniel, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to