| thiemowmde added a comment. |
I might be ignorant, but is the problem really that big that it deserves that much attention? All we need to do is to be aware of it (which we are now after the incident you are referring to) and repopulate the #wikidata-query-service database when we think we need to change the hashes again.
The only problematic line of code I can find in the current code is this one: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/Rdf/FullStatementRdfBuilder.php;c230481ef2c87f85bcb9780327e98b902193b51f$154. I can not think of a good alternative that would be worth the resources needed. The issue goes all the way down from SnakList to Snak to SnakObject to PropertyValueSnak to DataValueObject to every single class that implements the DataValue interface. Just looking for the remaining hash calculations that use serialize() would not solve the problem, as I tried to explain above, because the hashes will still break with ever other change we will make in the future. The only actual solution I can think of are GUIDs on all levels, which is going to be a huge breaking change to pretty much every single component we maintain. For what benefit?
Cc: thiemowmde, daniel, Aklapper, Smalyshev, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, debt, Gehel, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, JeroenDeDauw, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
