| thiemowmde triaged this task as "Normal" priority. thiemowmde moved this task from incoming to ready to go on the Wikidata board. thiemowmde added projects: Need-volunteer, MediaWiki-extensions-WikibaseRepository. thiemowmde added subscribers: Lydia_Pintscher, Addshore. thiemowmde added a comment. |
That is absolutely correct. There is a TODO in MwTimeIsoFormatter to replace the hard coded string with a message: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/Formatters/MwTimeIsoFormatter.php;6b923f763265e45f8cc008b49e43eff5ddad74bf$282. The message should be something like "$1 BCE". Such a message currently doesn't exist, just a bunch of "wikibase-time-precision-BCE-…" messages used by both MwTimeIsoFormatter as well as MwTimeIsoParser. The new message should be next to the existing ones.
Note that all date formats must round-trip! This means either MwTimeIsoParser or an other parser we have (e.g. YearTimeParser) must be able to parse all localized versions of BCE dates the MwTimeIsoFormatter outputs. I believe the best approach is to create a new version of an EraParser that knows about the BCE message introduced above (and must live in the lib directory because of this). That new parser would try to detect the message, and fall back to the existing EraParser if it couldn't find a localized one.
Even with this constraint I believe finally implementing this TODO might be a good volunteer task.
Cc: Addshore, Lydia_Pintscher, IKhitron, eranroz, thiemowmde, PokestarFan, Aklapper, matej_suchanek, Zppix, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Zoranzoki21, Srdjan_m, MuhammadShuaib, Izno, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, TheDJ, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
