eranroz added a comment. |
In T171564#3660992, @Jonas wrote:Is this how it should be?
F10018211: image.png
More or less yes. The most basic aliveness for it is having LTR for the code area/line numbers/cursor, and it looks like once Lucas patch is deployed it will be use-able in RTL languages.
There are some minor issues of much lower priority that we may want to address in the future like what Smalyshev pointed earlier, for example:
- Splitter - dragging left moves it right and vise versa
- Dropdown menus show left alignment (it may be valid for "tools", as tools have Latin names, and wrong for "help")
- It may be more correct to have the arrow icon mirrored in RTL
- X of the query helper should float left not right
- Some RTL languages (Arabic, Persian) mirror the question mark for help. In others (Hebrew and probably Yiddish) the question mark is same as in LTR languages (e.g currently shows correct)
TASK DETAIL
EMAIL PREFERENCES
To: eranroz
Cc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g
Cc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs