Krinkle added a comment. |
In T177311#3659950, @gerritbot wrote:Change 382383 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Split Echo hook handlers based on services needed
@aude Thanks for the quick patch!
public static function newFromGlobalState() { - $wikibaseClient = WikibaseClient::getDefaultInstance(); - $settings = $wikibaseClient->getSettings(); + $settings = WikibaseSettings::getClientSettings();
return new self( - $wikibaseClient->newRepoLinker(), - $wikibaseClient->getNamespaceChecker(), $settings->getSetting( 'echoIcon' ), );
Very nice. I didn't know WikibaseSettings::getClientSettings existed. That also avoids creating WikibaseClient's services.
TASK DETAIL
EMAIL PREFERENCES
To: aude, Krinkle
Cc: Lydia_Pintscher, gerritbot, hoo, aude, thiemowmde, Krinkle, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331
Cc: Lydia_Pintscher, gerritbot, hoo, aude, thiemowmde, Krinkle, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs