Gehel added a comment.

Looking at logs in logstash, it seems we throttled Recommendation API only when WDQS was overwhelmed by another user. Throttling is done on overall request time and the service was most probably already not responding correctly, or in a reasonable time.

My understanding at this point is that the flapping and alerting was reasonable. WDQS was returning 429 (throttling), but without throttling, it would probably have timed out.

Forwarding x-client-ip might still make sense. Or sending a user-agent combining the current UA and the end user UA.


TASK DETAIL
https://phabricator.wikimedia.org/T178445

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Gehel
Cc: mobrovac, Smalyshev, Gehel, Stashbot, Aklapper, Dzahn, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, Avner, Zppix, Volans, debt, Jonas, FloNight, Xmlizer, Eevans, jkroll, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to