| WMDE-leszek added a comment. |
Thanks @Ladsgroup for running another round of benchmark.
To make it clear what has been actually benchmarked. I've update the same patch that has been subject to analysis before, i.e. https://gerrit.wikimedia.org/r/#/c/345332/22. The patch itself has not really been changed, I've just updated it based the current state of the master.
Additionally, based on some comments @Smalyshev made, I've made some changes to several methods of EntityId (i.e. I didn't really make any changes to the Wikibase patch).
Namely, I've changed EntityId::getRepositoryName and EntityId::getLocalPart so that they're not doing splitting etc of the ID serialization but just generate those parts once. The actual change (which is the only thing changed for the whole new benchmark run) is https://github.com/wmde/WikibaseDataModel/commit/81f4186ea81f890769931322f4b36a3f6a0ae68d.
Other issues pointed in how some things are done in EntityId class are still there. These would require some more of fundamental change to make, so I have decided to try avoid them if possible.
@Smalyshev @daniel any comments, concerns about the new attempt? If the path seems fine, and the performance of the new code acceptable, I'ld turn https://github.com/wmde/WikibaseDataModel/commit/81f4186ea81f890769931322f4b36a3f6a0ae68d into actual pull request to Data Model library, and once it's in, https://gerrit.wikimedia.org/r/#/c/345332 could possibly be merged.
I guess it might be still interesting to look at what profiler says on the changed DataModel code. I believe @Ladsgroup could provide it if this would be of help.
Cc: hoo, Ladsgroup, PokestarFan, Lucas_Werkmeister_WMDE, Smalyshev, daniel, WMDE-leszek, Aklapper, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
