thiemowmde created this task. thiemowmde added projects: Wikidata, Lexicographical data, Wikidata-Sprint-2017-11-22. Herald added a subscriber: Aklapper. |
TASK DESCRIPTION
Both EntityDifferStrategy and EntityPatcherStrategy are (luckily) not abstract, but only interfaces. What I see needs to be done is:
- Make FormPatcher implement EntityPatcherStrategy.
- This should be trivial, basically renaming an existing method.
- Properly test all patcher methods.
- Make FormDiffer implement EntityDifferStrategy.
- Coming up with proper implementations for getConstructionDiff/getDestructionDiff might get a little tricky. Note that an "empty Form" should not contain a representation, otherwise the diff will not properly show the initial representation. The current implementation does not allow to construct a Form with no representation, but allows to remove all.
- Properly test all differ methods.
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: Jonas, Ladsgroup, WMDE-leszek, thiemowmde, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Darkdadaah, Mbch331
Cc: Jonas, Ladsgroup, WMDE-leszek, thiemowmde, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs