| Lucas_Werkmeister_WMDE added a comment. |
Alternative fix: wrap the user name in <nowiki>.
diff --git a/repo/i18n/en.json b/repo/i18n/en.json index c93cfa413..cacb8b4fe 100644 --- a/repo/i18n/en.json +++ b/repo/i18n/en.json @@ -369,8 +369,8 @@ "wikibase-self-conflict-patched": "Your edit was patched into the latest version, overriding some of your own intermediate changes.", "wikibase-conflict-patched": "Your edit was patched into the latest version.", "wikibase-restoreold": "restore", - "wikibase-entity-summary-restore": "Restore revision $3 by [[Special:Contributions/$4|{{GENDER:$4|$4}}]]", - "wikibase-entity-summary-undo": "Undo revision $3 by [[Special:Contributions/$4|{{GENDER:$4|$4}}]] ([[User talk:$4|talk]])", + "wikibase-entity-summary-restore": "Restore revision $3 by [[Special:Contributions/$4|{{GENDER:$4|<nowiki>$4</nowiki>}}]]", + "wikibase-entity-summary-undo": "Undo revision $3 by [[Special:Contributions/$4|{{GENDER:$4|<nowiki>$4</nowiki>}}]] ([[User talk:$4|talk]])", "wikibase-non-entity-diff": "Can not diff an entity with a non-entity content.", "wikibase-no-direct-editing": "Direct editing is disabled in namespace $1", "wikibase-noentity": "This entity does not exist. You can [{{fullurl:{{#Special:Log}}|page={{FULLPAGENAMEE}}}} search the related logs] to find out where it went.",
I’m only half joking – I think this fix does make some sense, since AutoCommentFormatter has no idea which arguments need to be escaped and which don’t (it just does the same thing for all messages), while the individual messages know what each argument means. That said, this is clearly a hack, and what’s worse, a hack that’s shown to all of our translators. Many of them will probably copy the <nowiki> into their translations even though it shouldn’t be necessary outside of the {{GENDER}} template.
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: gerritbot, Bawolff, Lucas_Werkmeister_WMDE, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331
Cc: gerritbot, Bawolff, Lucas_Werkmeister_WMDE, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
