Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.
Herald added a subscriber: Aklapper.

TASK DESCRIPTION

CheckConstraints::newFromGlobalState is not covered by any tests, so when one of the classes instantiated in there gains a constructor parameter, nothing besides manual testing reminds us to update the instantiation. It should be split up into several functions, most of which can be tested on their own. (newFromGlobalState should probably do nothing more except passing WikibaseRepo::getDefaultInstance() and MediaWikiServices::getInstance() into those functions.)


TASK DETAIL
https://phabricator.wikimedia.org/T183373

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to