2009/4/1 Yaron Koren <yaro...@gmail.com>: > Hi, > > The method showEditForm(), in the class EditPage, takes care of displaying > nearly the entire edit page. I would like to move the last section of this > method, which handles displaying the bottom of the edit page (everything > below the edit box) into its own method, perhaps called showFooter(). (This > basically corresponds to lines 1506 to 1566 of the current EditPage.php.) > showEditForm() would then call that new method. The reason for this move is > so that the extension Semantic Forms can subclass EditPage and override the > new method. But you could also make the case that it would improve > readability, modularity, whatever else. Any thoughts/objections? > I suggest you go ahead and do it: splitting out a piece of code into its own function is not a big deal, provided your choices of what to split out and what not to are somewhat sane.
Roan Kattouw (Catrope) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
