This raises the issue that started this going in the first place. Suppose I make the necessary modifications so "$wgScriptPath gets properly escaped when initialized." There could be all kinds of dependencies on this global scattered all over the place. Just running parserTests and getting them to pass isn't a sufficient regression test of the bug fix. Not only could parts of MW unrelated to the parser have built in assumptions about the way $wgScriptPath is formatted, there are a whole bunch of extensions that might also have similar assumptions.
MW really needs a better set of regression tests. --- On Tue, 7/21/09, Brion Vibber <br...@wikimedia.org> wrote: > From: Brion Vibber <br...@wikimedia.org> > Subject: Re: [Wikitech-l] There appears to be a bug in > WebRequest::extractTitle() > To: "Wikimedia developers" <wikitech-l@lists.wikimedia.org> > Date: Tuesday, July 21, 2009, 3:35 PM > dan nessett wrote: > > If I am reading the report correctly, fixing this bug > is going to > > require much more than a change here or there. It may > be better to > > simply require that URLs to wikis contain no blanks. > In any case, the > > quickest way for me to fix the problem is to change > the name of the > > directory where I store the latest trunk version. > > I *think* it should just take making sure $wgScriptPath > gets properly > escaped when initialized... but there may be exciting > snags. :) > > -- brion > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
