After fixing some bugs in /test/run-test, it now works. There are 7 PHPUnit
tests in /tests/. 4 pass and 3 have various failures. I am working on
LocalFileTest.php. It returns:
There was 1 failure:
1) testGetThumbVirtualUrl(LocalFileTest)
Failed asserting that two strings are equal.
expected string <mwrepo://test/public/thumb/Test%21>
difference < xxxxxxxxxxxxx???????>
got string <mwrepo://test/thumb/Test%21>
This problem arises in the function getThumbVirtualUrl() in
/phase3/includes/filerepo/File.php in the statement:
$path = $this->repo->getVirtualUrl() . '/thumb/' . $this->getUrlRel();
Obviously, the function is coded to return something different than the test
expects. The problem is, I don't know if this is a bug in the test or in the
code.
I have read the README file in the /filerepo/ directory and searched Bugzilla
for getThumbVirtualUrl(). The former didn't help with this problem and the
latter returned nothing.
Correcting this problem is easy. Either change what the test expects or change
the function to return what the test expects. I strongly suspect the correct
action is the former, but I have no idea what the code in /filerepo/ does. So,
I wonder if somewhat might either confirm or deny my strong suspicion? [Since
Tim Starling wrote the README file, perhaps he might comment]
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
