Assuming that both http://en.wikipedia.org/wiki/Special:BannerController http://en.wikipedia.org/w/index.php?title=Special:BannerController
will still return the same results, wouldn't it make more sense to teach the stat's logger to ignore both? Or is there a reason that we actually want to track one and not the other? It seems like an awful lot of trouble to teach every software author that they need to follow a particular convention just so the stats engine will work as intended. It would seem like it would be much simpler to teach the stats engine to simply detect and ignore this special case. Or is there a reason that doing so is not possible? -Robert Rohde On Tue, Oct 19, 2010 at 1:15 PM, Rob Lanphier <ro...@wikimedia.org> wrote: > Hi all, > > In diving into a problem with logging[1], we discovered that we were > unintentionally treating several special page accesses (in this case, > containing included Javascript) as normal pageviews, thus throwing our > pageview statistics way off. The proposed solution involves changing > the way we access those Javascript requests from this form: > http://en.wikipedia.org/wiki/Special:BannerController > > ...to this form: > http://en.wikipedia.org/w/index.php?title=Special:BannerController > > I'm assuming this convention isn't documented anywhere (other than > earlier today on the wikitech wiki[2]). Before we run off and > document this as something code reviewers need to look out for, I'd > like to make sure this is really how we'd like to make the > distinction. > > Is this a sensible convention, or is there a different convention we > should implement? Note that any changes to the convention would need > to be implemented here: > http://svn.wikimedia.org/viewvc/mediawiki/trunk/webstatscollector/filter.c?view=markup > > ...so futzing with the convention isn't free, but *may* be worth it if > we have arrive at a vastly superior convention. > > Rob > [1] https://bugzilla.wikimedia.org/show_bug.cgi?id=25564 > [2] http://wikitech.wikimedia.org/view/Squid_logging#Inflated_Stats > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
