User "Tbleher" posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c16041 Commit summary:
Add a getSkin that returns a dummy linker for BC with extensions still abusing it to access the linker. Comment: Sorry, I think my messages were worded poorly. To clarify: the main "fixme" issue I see here is that the function added doesn't do what it says, because it doesn't actually return a Skin object. Either the function should be changed to return a Skin object, or it should be removed. The second option would at least generate a clear error message for any code calling this function (I had to stare at the SMW code for a while until I understood that it broke because getSkin() did no longer return a Skin object) I should also add that I appreciate Dantmans work to make the code clearer and refactor it. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
