User "Tim Starling" changed the status of MediaWiki.r85635. Old Status: new New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r85635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85635#c16478 Commit summary: First part of bug 22881: Allow uploading directly into the archive to support importing files. Based on a patch by Vitaliy Filippov with some major rewrites by me. * LocalFile::publish() supports an extra parameter to support publishing into the archive * Added OldLocalFile::uploadOld(), which is the OldImage equivalent to LocalFile::upload(), but does not override it because it has an entirely different function signature. Comment: Causes "<b>Strict Standards</b>: Declaration of ForeignDBFile::publish() should be compatible with that of LocalFile::publish() in <b>.../ForeignDBFile.php</b> on line <b>57</b>". There's no reason this feature has to be limited to LocalFile. I'm not sure why you changed LocalFile::publish() at all, since basically the only thing that it does is calculates the archive name. Why not just use FileRepo::publish() directly? Or add a helper function to File/LocalFile with a different name. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
