User "Siebrand" changed the status of MediaWiki.r87637. Old Status: new New Status: fixme
User "Siebrand" also posted a comment on MediaWiki.r87637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87637#c16663 Commit summary: Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in Defines.php. This requires loading Defines.php before the PHP4 version checks, so include a big note reminding people not to include anything other than vanilla define() statements in there. I have a sneaking suspicion that including Defines.php in the entry points might not play nicely with HipHop, but I can't test it (wrong OS). Comment: PHP Warning: require_once(/www/w/maintenance/includes/Defines.php): failed to open stream: No such file or directory in /www/w/maintenance/Maintenance.php on line 24 PHP Fatal error: require_once(): Failed opening required '/www/w/maintenance/includes/Defines.php' (include_path='.:/usr/share/php:/usr/share/pear') in /www/w/maintenance/Maintenance.php on line 24 _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview