User "Happy-melon" posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16676 Commit summary:
* Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: Anyone running a modified version of MW can and should hack the version number along with whatever else they've changed, precisely ''so that'' it gets reverted along with any other changes if they do an upgrade without repatching. Updating the version via LocalSettings, which won't get overwritten by an upgrade, and the code via core hacks which will, is asking for (more than the usual amount of) trouble. I can see merit in a <tt>wfGetVersionText()</tt> function which can be hooked to change the display on things like Special:Version and the <meta generator> tag, but being able to fudge <tt>version_compare()</tt> calls is neither big nor clever. <tt>MW_VERSION</tt> summarises the state of the other 714,000 lines of code in MW core, version comparisons exist to stop Bad Things™ happening when those structures don't match up with what external code expects to see. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
