User "Brion VIBBER" posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16735 Commit summary:
obtain URL from page title of alternate upload form Comment: Doesn't check for errors; mw.Title() constructor appears to throw an exception on some invalid input -- and also on what appears to be perfectly valid input such as 'Commonsx:Upload' (throws "unrecognized namespace prefix", which it should not -- that should just come through as the local page titled 'Commonsx:Upload'). If given invalid input, should probably fall back to the standard link or at least rethrow the error with specificity, so the console error log shows that it was a problem with the altUploadForm setting for UploadWizard extension. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview